On Tue, Nov 29, 2011 at 11:47 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Tue, 2011-11-29 at 08:33 -0800, Stanislav Yakovlev wrote:
>> >> It would be much less risky to convert the entire thing to cfg80211, I
>> >> think, basically just replacing the configuration layer in libipw_wx.c
>> >> with a cfg80211 based one.
>> >
>> > It might also be a good idea to do some cleanups first -- e.g. I notice,
>> > just in a random look at the code, that reset_port isn't used anywhere
>> > so all code related to that can be removed...
>>
>> Do I understand correctly that you suggest remove reset_port from
>> libipw_device struct
>> and remove all code like this:
>>
>> - if (ieee->reset_on_keychange &&
>> - ieee->iw_mode != IW_MODE_INFRA &&
>> - ieee->reset_port && ieee->reset_port(dev)) {
>> - LIBIPW_DEBUG_WX("%s: reset_port failed\n", dev->name);
>> - return -EINVAL;
>> - }
>>
>> from libipw_wx.c ?
>
> Right. There might be more of this too. That'd just help with converting
> since you wouldn't have to think about converting this at all.
Would you be up to convert prism54 too? :)
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
