Search Linux Wireless

[RFC] prism54: fix compilation warning on wrqu.data.pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This fixes this compilation warning:

  CHECK   drivers/net/wireless/prism54/isl_ioctl.c
drivers/net/wireless/prism54/isl_ioctl.c:2052:27: warning: incorrect type in assignment (different address spaces)
drivers/net/wireless/prism54/isl_ioctl.c:2052:27:    expected void [noderef] <asn:1>*pointer
drivers/net/wireless/prism54/isl_ioctl.c:2052:27:    got char *[assigned] memptr
drivers/net/wireless/prism54/isl_ioctl.c:2071:27: warning: incorrect type in assignment (different address spaces)
drivers/net/wireless/prism54/isl_ioctl.c:2071:27:    expected void [noderef] <asn:1>*pointer
drivers/net/wireless/prism54/isl_ioctl.c:2071:27:    got char *[assigned] memptr

The wrqu.data.pointer shouldn't be assigned by the driver, addiotionally
custom wext driver events would simply be dropped anyway.

Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxxxxxxxx>
---

Johannes, it was unclear to me whether or not wireless_send_event()
no longer supports custom driver events if so then not only was this
bogus but also all the private driver event crap could likely be
removed from prism54 as well.

 drivers/net/wireless/prism54/isl_ioctl.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/prism54/isl_ioctl.c b/drivers/net/wireless/prism54/isl_ioctl.c
index 4e44b1a..862dfea 100644
--- a/drivers/net/wireless/prism54/isl_ioctl.c
+++ b/drivers/net/wireless/prism54/isl_ioctl.c
@@ -2049,7 +2049,6 @@ send_formatted_event(islpci_private *priv, const char *str,
 	memptr = kmalloc(IW_CUSTOM_MAX, GFP_KERNEL);
 	if (!memptr)
 		return;
-	wrqu.data.pointer = memptr;
 	wrqu.data.length = 0;
 	format_event(priv, memptr, str, mlme, &wrqu.data.length,
 		     error);
@@ -2068,7 +2067,6 @@ send_simple_event(islpci_private *priv, const char *str)
 	if (!memptr)
 		return;
 	BUG_ON(n >= IW_CUSTOM_MAX);
-	wrqu.data.pointer = memptr;
 	wrqu.data.length = n;
 	strcpy(memptr, str);
 	wireless_send_event(priv->ndev, IWEVCUSTOM, &wrqu, memptr);
-- 
1.7.4.15.g7811d

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux