On Wednesday 23 November 2011 09:02 PM, Felix Fietkau wrote:
Doing reset from tasklet context created several nasty stability issues that were hard to track down, and the potential gain from doing reset 'immediately' that way is purely theoretical. Resets should be rare in normal operation, as they're also expensive. The main problem when running reset from a tasklet is that there is no way of gracefully shutting down ongoing workqueue activity, so the result of the reset could be that the work items mess up the state right after the reset is done.
thanks, true in this case ath_reset is called from tasklet context. i will send a v2 for using queue_work.
- Felix
-- thanks, shafi -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html