Search Linux Wireless

Re: [PATCH 16/18] ath9k: make ath_reset non-static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Felix,

thanks for your review.
On Wednesday 23 November 2011 07:59 PM, Felix Fietkau wrote:
On 2011-11-22 11:22 PM, Mohammed Shafi Shajakhan wrote:
From: Mohammed Shafi Shajakhan<mohammed@xxxxxxxxxxxxxxxx>

to be used by MCI specific changes

Cc: Wilson Tsao<wtsao@xxxxxxxxxxxxxxxx>
Cc: Senthil Balasubramanian<senthilb@xxxxxxxxxxxxxxxx>
Signed-off-by: Rajkumar Manoharan<rmanohar@xxxxxxxxxxxxxxxx>
Signed-off-by: Mohammed Shafi Shajakhan<mohammed@xxxxxxxxxxxxxxxx>
NACK. ath_reset can no longer be called in tasklet context (which you
seem to be doing in the next patch).
Replace your ath_reset() call with:
   ieee80211_queue_work(sc->hw,&sc->hw_reset_work);

- Felix

just like in ath9k_flush, i like to have the chip reset immediately rather than queuing at as a work.
in chip reset we have:
*we have BT calibration
*sync up with BT state
*2g_5g change
*LNA transfer
and few other things

when BT asks for calibration i understand we have to immediately give preference to it. please let me know if i had missed something and also if queuing ath_reset actually helps us in some way.
i will revert this back once i test queue_work does no harm.


--
thanks,
shafi
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux