From: Johannes Berg <johannes.berg@xxxxxxxxx>
First time I tried smatch, and it says:
mesh_hwmp.c +870 mesh_queue_preq(21) error: double lock 'bottom_half:'
mesh_hwmp.c +873 mesh_queue_preq(24) error: double unlock 'bottom_half:'
mesh_hwmp.c +886 mesh_queue_preq(37) error: double unlock 'bottom_half:'
Which is indeed true -- there's no point in disabling BHs
again if we just did that a few lines earlier, so remove.
Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
---
net/mac80211/mesh_hwmp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/net/mac80211/mesh_hwmp.c 2011-11-18 09:46:26.000000000 +0100
+++ b/net/mac80211/mesh_hwmp.c 2011-11-18 15:25:36.000000000 +0100
@@ -867,9 +867,9 @@ static void mesh_queue_preq(struct mesh_
return;
}
- spin_lock_bh(&mpath->state_lock);
+ spin_lock(&mpath->state_lock);
if (mpath->flags & MESH_PATH_REQ_QUEUED) {
- spin_unlock_bh(&mpath->state_lock);
+ spin_unlock(&mpath->state_lock);
spin_unlock_bh(&ifmsh->mesh_preq_queue_lock);
kfree(preq_node);
return;
@@ -879,7 +879,7 @@ static void mesh_queue_preq(struct mesh_
preq_node->flags = flags;
mpath->flags |= MESH_PATH_REQ_QUEUED;
- spin_unlock_bh(&mpath->state_lock);
+ spin_unlock(&mpath->state_lock);
list_add_tail(&preq_node->list, &ifmsh->preq_queue.list);
++ifmsh->preq_queue_len;
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
