On Fri, 2011-11-18 at 17:09 +0300, Dan Carpenter wrote:
> This function makes the static checkers grumble. The return value of
> snprintf() is the number of bytes which would have been copied if
> there was enough space. In theory, a %u can take take 10 digits so
> len could be larger than 16 and it would be a small information
> leak.
>
> We may as well make the buffer larger as well since that is very
> easy to do.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c
> index 9eff0d0..e632008 100644
> --- a/drivers/net/wireless/ath/ath6kl/debug.c
> +++ b/drivers/net/wireless/ath/ath6kl/debug.c
> @@ -1551,11 +1551,12 @@ static ssize_t ath6kl_listen_int_read(struct file *file,
> size_t count, loff_t *ppos)
> {
> struct ath6kl *ar = file->private_data;
> - char buf[16];
> + char buf[32];
> int len;
>
> len = snprintf(buf, sizeof(buf), "%u %u\n", ar->listen_intvl_t,
> ar->listen_intvl_b);
> + len = min(sizeof(buf), len);
Maybe that should be scnprintf instead then?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
