On Fri, Nov 18, 2011 at 12:12:24PM +0100, Johannes Berg wrote:
> On Fri, 2011-11-18 at 12:01 +0100, Simon Wunderlich wrote:
>
> > - if (is_multicast_ether_addr(hdr->addr1))
> > + if (is_multicast_ether_addr(hdr->addr1) ||
> > + (sdata->noack_map & 1 << tid)) {
>
> I'd prefer this:
>
> if (is_multicast_ether_addr(...) ||
> sdata->noack_map & BIT(tid))
>
> (Note indentation & use of BIT())
OK
>
> Isn't this missing an update to ieee80211_duration() now?
Yep, I silently dropped that modification - I rather don't mess with stuff I
don't completly understand. Keeping the duration too long shouldn't hurt
(only performance), having it too short will have much worse effects ...
Thanks,
Simon
Attachment:
signature.asc
Description: Digital signature
