Search Linux Wireless

Re: [PATCHv3 3/3] mac80211: Add NoAck per tid Support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2011-11-18 at 12:01 +0100, Simon Wunderlich wrote:

> -		if (is_multicast_ether_addr(hdr->addr1))
> +		if (is_multicast_ether_addr(hdr->addr1) ||
> +			(sdata->noack_map & 1 << tid)) {

I'd prefer this:

		if (is_multicast_ether_addr(...) ||
		    sdata->noack_map & BIT(tid))

(Note indentation & use of BIT())

Isn't this missing an update to ieee80211_duration() now?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux