In fact, could this be made contingent on whether there's an AP-mode interface, since the problem you're encountering seems to only be in AP mode? What troubles me, Felix, is your statement that " this series fixes some "PCI error" crashes". Does this mean that you haven't root-caused the problem, and that this may only partially mask it? -- Paul On Wed, Nov 16, 2011 at 10:23 AM, Luis R. Rodriguez <mcgrof@xxxxxxxxxxxxxxxx> wrote: > On Wed, Nov 16, 2011 at 10:16 AM, Felix Fietkau <nbd@xxxxxxxx> wrote: >> On 16.11.2011, at 18:42, "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxx> wrote: >> >>> On Wed, Nov 16, 2011 at 4:08 AM, Felix Fietkau <nbd@xxxxxxxxxxx> wrote: >>>> Turning off the radio when mac80211 tells the driver that it's idle is not >>>> a good idea, as idle interfaces might still occasionally scan or send packets. >>>> The only time the radio can be safely turned off is when drv_stop has been >>>> called. In the mean time, use sc->ps_idle only to indicate network sleep vs >>>> full sleep. >>>> Move the LED GPIO changes out of the PCI suspend/resume path, the start/stop >>>> functions already take care of that. >>>> >>>> Signed-off-by: Felix Fietkau <nbd@xxxxxxxxxxx> >>> >>> This set of patches are going to need some good amount of testing for >>> power impact. The benefits and gains need to be considered. I'll yield >>> to Senthil and Paul for final approval on this. >> >> One of the gains is that this series fixes some "PCI error" crashes >> on OpenWrt during hostapd restarts. > > Thanks for the clarification, I was expecting this to be the case, the > point I am trying to make though is that this "fix" itself may > introduce a regression for non-AP devices, specifically in terms of > power consumption and I'd like the stakeholders who do care about that > to review these changes carefully as well. The difficulty will be to > find a reasonable middle ground. > > Luis > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
