On 16.11.2011, at 18:42, "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxx> wrote: > On Wed, Nov 16, 2011 at 4:08 AM, Felix Fietkau <nbd@xxxxxxxxxxx> wrote: >> Turning off the radio when mac80211 tells the driver that it's idle is not >> a good idea, as idle interfaces might still occasionally scan or send packets. >> The only time the radio can be safely turned off is when drv_stop has been >> called. In the mean time, use sc->ps_idle only to indicate network sleep vs >> full sleep. >> Move the LED GPIO changes out of the PCI suspend/resume path, the start/stop >> functions already take care of that. >> >> Signed-off-by: Felix Fietkau <nbd@xxxxxxxxxxx> > > This set of patches are going to need some good amount of testing for > power impact. The benefits and gains need to be considered. I'll yield > to Senthil and Paul for final approval on this. One of the gains is that this series fixes some "PCI error" crashes on OpenWrt during hostapd restarts. - Felix-- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html