On Tue, 2011-11-08 at 21:12 +0100, Johannes Berg wrote:
> For example here:
>
> > if (!(ap_ht_cap_flags & IEEE80211_HT_CAP_40MHZ_INTOLERANT) &&
> > + !ieee80111_cfg_override_disables_ht40(sdata) &&
> > (sband->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40) &&
> > (hti->ht_param & IEEE80211_HT_PARAM_CHAN_WIDTH_ANY)) {
> > switch(hti->ht_param & IEEE80211_HT_PARAM_CHA_SEC_OFFSET) {
>
> This just adds complexity. If you calculate sdata->used_ht_caps first
> then you can replace the sband->ht_cap.cap check with an
> sdata->used_ht_caps.cap check and be done with it, instead of having to
> check both.
Similarly in ieee80211_add_ht_ie(), you wouldn't have to re-calculate
the override, etc. I think it would be a lot simpler that way.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
