On Tue, 2011-11-08 at 11:36 -0800, greearb@xxxxxxxxxxxxxxx wrote:
> +bool ieee80111_cfg_override_disables_ht40(struct ieee80211_sub_if_data *sdata)
> +{
> + if ((sdata->u.mgd.ht_capa_mask.cap_info &
> + IEEE80211_HT_CAP_SUP_WIDTH_20_40) &&
> + !(sdata->u.mgd.ht_capa.cap_info &
> + IEEE80211_HT_CAP_SUP_WIDTH_20_40))
> + return true;
> + return false;
Would it really go above 80 cols if you didn't line-wrap it? Maybe
remove the extra sets of parentheses? And even if it goes to a little
bit above 80 it's still be more readable without the wrapping ...
One thing I don't quite understand: Why don't you calculate the HT caps
to use upon assoc request, and then store *those* instead, then you
wouldn't have to check the overrides every time.
For example here:
> if (!(ap_ht_cap_flags & IEEE80211_HT_CAP_40MHZ_INTOLERANT) &&
> + !ieee80111_cfg_override_disables_ht40(sdata) &&
> (sband->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40) &&
> (hti->ht_param & IEEE80211_HT_PARAM_CHAN_WIDTH_ANY)) {
> switch(hti->ht_param & IEEE80211_HT_PARAM_CHA_SEC_OFFSET) {
This just adds complexity. If you calculate sdata->used_ht_caps first
then you can replace the sband->ht_cap.cap check with an
sdata->used_ht_caps.cap check and be done with it, instead of having to
check both.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
