Hi Johannes, >> + /* Absence of SSID or zero-sized SSID is used as >> + * an indication of the hidden bss. */ >> + if (!ie2 || !ie2[1]) >> + return 0; > > I don't think that's right -- I never saw anything w/o an SSID IE except > for mesh networks I think. Also this has different semantics from the > regular rb-tree search which will return -1 if not present (which is > actually a bug). Ok, agree. > Since we need to fix cmp_ie() anyway, how about we change it there as > well. I'm going to post a patch. > I assume there is some (unclear for me) idea behind the order of operation in the cmp_ie comparator. Natural order of scan output? >> + /* TODO: The code is not trying to update existing probe >> + * response bss entries when beacon ies are >> + * getting changed. */ > > This is nicer, though I'd prefer the TODO was addressed as well since > now we'll forever show stale data, this seems a bit bad. > We'll discuss it and maybe will redesign bss cache a bit, but not in a scope of this patch. I do not like stale data in IEs as well - from end-user prospective WPS likely will not work. With best regards, Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
