On Wed, 2011-11-02 at 22:55 -0700, greearb@xxxxxxxxxxxxxxx wrote:
> From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>
> This allows a user to configure a wifi station interface
> to disable the HT features, even if the AP and NIC supports it.
I like this version much better. Some nitpicks:
> +#define ASSOC_REQ_DISABLE_HT (1<<0) /* Disable HT (802.11n) */
You could use an enum to use kernel-doc notation here.
> @@ -1046,6 +1048,7 @@ struct cfg80211_auth_request {
> * @use_mfp: Use management frame protection (IEEE 802.11w) in this association
> * @crypto: crypto settings
> * @prev_bssid: previous BSSID, if not %NULL use reassociate frame
> + * @flags: See ASSOC_REQ_* flags above.
and then say "See &enum cfg80211_assoc_req_flags" or so should even
create the correct link in kernel-doc output.
> @@ -1053,6 +1056,7 @@ struct cfg80211_assoc_request {
> size_t ie_len;
> struct cfg80211_crypto_settings crypto;
> bool use_mfp;
> + u32 flags;
Seems like it might be good for use_mfp to become a flag? Anyway,
internal APIs are easy to change.
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
I'd rather split this up into cfg80211/mac80211. In fact, maybe
splitting it into one cfg80211 and one mac80211 patch, instead of three
different patches that span both might be worthwhile?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
