On 11/02/2011 12:53 AM, Johannes Berg wrote:
On Fri, 2011-10-28 at 11:55 -0700, Ben Greear wrote:
This should be a parameter to connect() and assoc(), not a generic
netdev parameter, since it applies to the connection.
Also, it would be good to have a capability check for it etc. since a
lot of fullmac drivers will likely never implement this.
The existing code always sets the IEEE80211_STA_DISABLE_11N flag in u.mgd if
WEP or TKIP is configured, without any capability checks, and my patch
sets that flag in the same location.
So, maybe it is OK as is?
If not, I will add a new capability bit and just enable
it in ath9k (and let others enable it in their drivers as they wish).
You misunderstood -- I said fullmac drivers, not differences between
ath9k, iwlwifi etc. Other cfg80211 drivers, not other mac80211 drivers.
Can you at least point me to some existing code that does a similar
check? I have no idea of what a fullmac driver even does. I can test
and eventually somewhat understand the paths for ath9k, but I have no
ability to test fullmac (as far as I know).
If you don't have time to explain in more detail, then I will just
carry these patches in my own tree. That is a total pain in
the arse when dealing with new netlink commands, but I just do not
have enough understanding of the entire wifi stack to make much
progress with a lot of your suggestions.
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
