On 10/28/2011 01:08 AM, Johannes Berg wrote:
On Thu, 2011-10-27 at 22:11 -0700, greearb@xxxxxxxxxxxxxxx wrote:
+++ b/net/wireless/nl80211.c @@ -1641,6 +1641,13 @@ static int nl80211_set_interface(struct sk_buff *skb, struct genl_info *info) change = true; } + if (info->attrs[NL80211_ATTR_DISABLE_11N]) { + params.disable_11n = !!nla_get_u8(info->attrs[NL80211_ATTR_DISABLE_11N]); + change = true; + } else { + params.disable_11n = -1; + }This should be a parameter to connect() and assoc(), not a generic netdev parameter, since it applies to the connection. Also, it would be good to have a capability check for it etc. since a lot of fullmac drivers will likely never implement this.
The existing code always sets the IEEE80211_STA_DISABLE_11N flag in u.mgd if WEP or TKIP is configured, without any capability checks, and my patch sets that flag in the same location. So, maybe it is OK as is? If not, I will add a new capability bit and just enable it in ath9k (and let others enable it in their drivers as they wish). Thanks, Ben -- Ben Greear <greearb@xxxxxxxxxxxxxxx> Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
