On Tue, Oct 4, 2011 at 2:01 PM, Zefir Kurtisi <zefir.kurtisi@xxxxxxxxxxx> wrote:
> On 10/03/2011 08:15 PM, Luis R. Rodriguez wrote:
>> On Mon, Oct 3, 2011 at 3:29 AM, Zefir Kurtisi <zefir.kurtisi@xxxxxxxxxxx> wrote:
>>>
>>> Signed-off-by: Zefir Kurtisi <zefir.kurtisi@xxxxxxxxxxx>
>>> ---
>>> drivers/net/wireless/ath/ath.h | 34 ++++++++++++++++++----------------
>>> 1 files changed, 18 insertions(+), 16 deletions(-)
>>>
>>> diff --git a/drivers/net/wireless/ath/ath.h b/drivers/net/wireless/ath/ath.h
>>> index 6d56532..34d4da1 100644
>>> --- a/drivers/net/wireless/ath/ath.h
>>> +++ b/drivers/net/wireless/ath/ath.h
>>> @@ -211,6 +211,7 @@ ath_printk(const char *level, struct ath_common *common, const char *fmt, ...);
>>> * @ATH_DBG_HWTIMER: hardware timer handling
>>> * @ATH_DBG_BTCOEX: bluetooth coexistance
>>> * @ATH_DBG_BSTUCK: stuck beacons
>>> + * @ATH_DBG_DFS: radar datection
>>> * @ATH_DBG_ANY: enable all debugging
>>> *
>>> * The debug level is used to control the amount and type of debugging output
>>> @@ -220,22 +221,23 @@ ath_printk(const char *level, struct ath_common *common, const char *fmt, ...);
>>> * entry.
>>> */
>>> enum ATH_DEBUG {
>>> - ATH_DBG_RESET = 0x00000001,
>>> - ATH_DBG_QUEUE = 0x00000002,
>>> - ATH_DBG_EEPROM = 0x00000004,
>>> - ATH_DBG_CALIBRATE = 0x00000008,
>>> - ATH_DBG_INTERRUPT = 0x00000010,
>>> - ATH_DBG_REGULATORY = 0x00000020,
>>> - ATH_DBG_ANI = 0x00000040,
>>> - ATH_DBG_XMIT = 0x00000080,
>>> - ATH_DBG_BEACON = 0x00000100,
>>> - ATH_DBG_CONFIG = 0x00000200,
>>> - ATH_DBG_FATAL = 0x00000400,
>>> - ATH_DBG_PS = 0x00000800,
>>> - ATH_DBG_HWTIMER = 0x00001000,
>>> - ATH_DBG_BTCOEX = 0x00002000,
>>> - ATH_DBG_WMI = 0x00004000,
>>> - ATH_DBG_BSTUCK = 0x00008000,
>>> + ATH_DBG_RESET = BIT(0),
>>> + ATH_DBG_QUEUE = BIT(1),
>>> + ATH_DBG_EEPROM = BIT(2),
>>> + ATH_DBG_CALIBRATE = BIT(3),
>>> + ATH_DBG_INTERRUPT = BIT(4),
>>> + ATH_DBG_REGULATORY = BIT(5),
>>> + ATH_DBG_ANI = BIT(6),
>>> + ATH_DBG_XMIT = BIT(7),
>>> + ATH_DBG_BEACON = BIT(8),
>>> + ATH_DBG_CONFIG = BIT(9),
>>> + ATH_DBG_FATAL = BIT(10),
>>> + ATH_DBG_PS = BIT(11),
>>> + ATH_DBG_HWTIMER = BIT(12),
>>> + ATH_DBG_BTCOEX = BIT(13),
>>> + ATH_DBG_WMI = BIT(14),
>>> + ATH_DBG_BSTUCK = BIT(15),
>>> + ATH_DBG_DFS = BIT(16),
>>> ATH_DBG_ANY = 0xffffffff
>>
>> Split this into two patches, one to convert stuff to BIT(foo) and the
>> other one to add ATH_DBG_DFS
> In fact, the BIT values will be reverted, since it is easier to have the hex values when setting debug mask than the bit position (for me at least).
yes, i agree having hex values is much better. especially when we
have a combination of 2 or 3 debug masks for debugging issues.
thanks!
>>
>> Luis
>
> Thanks,
> Zefir
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
shafi
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
