On Fri, 2011-09-16 at 13:41 +0200, Johannes Berg wrote: > FWIW, I think the check there pre-dates the current cfg80211/mac80211 > design. The current assumption in mac80211 clearly is that ifibss->bssid > is *always* valid since it's set to a random address when asked to join. > Hence the only way it can be invalid is the bug case you reported (join > fixed zeroes BSSID). Actually, that's not true. And in fact, setting a fixed BSSID with a zero address will cause some funny things to happen, but not necessarily what you think :-) The is_zero_ether_addr() check there means "have we found an IBSS already?" and as such must stay. It doesn't mean "do we have a valid configuration" at all... johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
