On Fri, 2011-09-16 at 05:14 +0200, Marek Lindner wrote: > On Thursday, September 15, 2011 18:21:38 Johannes Berg wrote: > > How is this related to configuration? > > These 'sdata->u.ibss' values are initialized by ieee80211_ibss_join() which is > called when a user invokes "iw dev wlan0 ibss join". Right. So that means you shouldn't be rejecting the configuration when actually using it. You should be rejecting it when it's actually set. > > Shouldn't the configuration check be in cfg80211 instead? > > No idea. I just stumbled over this obvious bug when I scrolled down the code. > Feel free to propose an alternative patch if you have a better solution. It should be in cfg80211, so NACK for this patch. Also, this patch is wrong -- at that point, checking for zero address serves a difference purpose I think, it means more something along the lines of "did we previously find an IBSS". johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
