Search Linux Wireless

Re: mac80211 driver for RT3070 wifi card does not work on big-endian platform

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I noticed two lines of code:
                static const u32 wcid[2] = { 0xffffffff, 0x00ffffff };
                rt2800_register_multiwrite(rt2x00dev, MAC_WCID_ENTRY(i),
                                              wcid, sizeof(wcid));

Do you think the first line should be changed as below to eliminate
platform difference?
                static const u32 wcid[2] = { 0xffffffff,
cpu_to_le32(0x00ffffff) };


On Fri, Sep 9, 2011 at 9:55 PM, Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote:
> On 09/09/2011 07:05 AM, Semigod King wrote:
>>
>> Larry,
>> Thank you for looking at this issue. I will try your code change tonight
>> and let
>> you know test results. I have an openwrt cross build system ready on my
>> freebsd
>> at home.
>
> That will not change a thing. Other than trip some sparse warnings,
> le32_to_cpu() and cpu_to_le32() do the same thing. On little-endian boxes,
> they are a no-op, and on big-endian platforms, they both reverse the byte
> order. Switching the call only makes it clearer what is happening.
>
> I am having trouble getting Ubuntu 11.04 running on my Macbook. The OS is
> installed, but no X at the moment.
>
> BTW, please do not drop the Cc to wireless. I want to keep the ML in the
> loop.
>
> Larry
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux