On Thu, Sep 1, 2011 at 10:11 AM, Felix Fietkau <nbd@xxxxxxxxxxx> wrote: > On 2011-09-01 7:01 PM, Luis R. Rodriguez wrote: >> >> On Wed, Aug 31, 2011 at 4:32 PM, Felix Fietkau<nbd@xxxxxxxxxxx> wrote: >>> >>> reduces unnecessary code duplication. Also takes the sc_pcu_lock within >>> ath_reset instead of callsites, which makes it possible to always cancel >>> all queued work items before the reset, possibly fixing a few race >>> conditions (work items vs reset) along with it. >>> >>> Signed-off-by: Felix Fietkau<nbd@xxxxxxxxxxx> >> >> This was a bit hard to review, if helpers are being added can they be >> added without changing code around, and in some other patch make the >> changes you describe? > > I don't think it can be easily split up, because the change to use the > helper functions depends other things like the change to queue the reset > work instead of calling ath_reset directly. OK thanks, its just hard to review, I cannot really make much of it but I trust you :) Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
