Search Linux Wireless

Re: [PATCH v11 3/4] ath9k: merge reset related functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2011-09-01 7:01 PM, Luis R. Rodriguez wrote:
On Wed, Aug 31, 2011 at 4:32 PM, Felix Fietkau<nbd@xxxxxxxxxxx>  wrote:
 reduces unnecessary code duplication. Also takes the sc_pcu_lock within
 ath_reset instead of callsites, which makes it possible to always cancel
 all queued work items before the reset, possibly fixing a few race
 conditions (work items vs reset) along with it.

 Signed-off-by: Felix Fietkau<nbd@xxxxxxxxxxx>

This was a bit hard to review, if helpers are being added can they be
added without changing code around, and in some other patch make the
changes you describe?
I don't think it can be easily split up, because the change to use the helper functions depends other things like the change to queue the reset work instead of calling ath_reset directly.

- Felix
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux