On Mon, Aug 29, 2011 at 07:54:21AM +0200, Felix Fietkau wrote:
> Signed-off-by: Felix Fietkau <nbd@xxxxxxxxxxx>
> ---
> drivers/net/wireless/ath/ath9k/ar9002_phy.c | 6 ++++--
> drivers/net/wireless/ath/ath9k/ar9003_phy.c | 6 ++++--
> drivers/net/wireless/ath/ath9k/hw-ops.h | 6 ++++--
> 3 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/ar9002_phy.c b/drivers/net/wireless/ath/ath9k/ar9002_phy.c
> index 3cbbb03..38e91f8 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9002_phy.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9002_phy.c
> @@ -570,8 +570,10 @@ void ar9002_hw_attach_phy_ops(struct ath_hw *ah)
> priv_ops->compute_pll_control = ar9002_hw_compute_pll_control;
> priv_ops->do_getnf = ar9002_hw_do_getnf;
>
> - ops->antdiv_comb_conf_get = ar9002_hw_antdiv_comb_conf_get;
> - ops->antdiv_comb_conf_set = ar9002_hw_antdiv_comb_conf_set;
> + if (AR_SREV_9285(ah)) {
> + ops->antdiv_comb_conf_get = ar9002_hw_antdiv_comb_conf_get;
> + ops->antdiv_comb_conf_set = ar9002_hw_antdiv_comb_conf_set;
> + }
>
Better to return from ar900*_hw_antdiv_comb_conf_set/get based on
hw capability (ATH9K_HW_CAP_ANT_DIV_COMB) rathar than adding chip specific
checks. That looks to be more generic.
--
Rajkumar
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
