On 08/24/2011 05:52 PM, Vasanthakumar Thiagarajan wrote: > On Wed, Aug 24, 2011 at 05:46:21PM +0300, Kalle Valo wrote: >> On 08/24/2011 05:25 PM, Vasanthakumar Thiagarajan wrote: >>> +#ifdef CONFIG_ATH6KL_DEBUGFS >>> +int ath6kl_init_debugfs(struct ath6kl *ar) >>> +{ >>> + ar->debugfs_phy = debugfs_create_dir("ath6kl", >>> + ar->wdev->wiphy->debugfsdir); >> >> What if we have multiple devices on same host? Then this won't work, >> right? Maybe we should have some kind of subdirectory under ath6kl or >> something like that. > > I don't think we need to worry about multiple device case, it is > entirely different wiphy. But when were are two devices, both will try create /sys/kernel/debug/athk6kl and second one is bound to fail. Ah, but now I see where I'm wrong. The directory will be under wiphy debugfsdir, eg. /sys/kernel/debug/phy0/, and there's no issue with multiple devices. Sorry, I missed this. So forget all I said :) > May be multiple virtual interface needs to be > taken care? Anyway, currently ath6kl does not support more than > one virtual interface, can be addressed later. Yeah, no need to worry that now. Kalle -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html