On Wed, 2011-08-10 at 18:44 +0200, Michael Büsch wrote: > > >> + if (dev->id.coreid == SSB_DEV_80211) > > >> + return (chip_id == 0x4322 || chip_id == 43221 || > > >> + chip_id == 43231 || chip_id == 43222); > > >> + return 0; > > >> +} > > > > > > ACK, apart from this coding style violation (missing curly braces). > > > > From kernel CodingStyle: > > > Do not unnecessarily use braces where a single statement will do. > > > > > > if (condition) > > > action(); > > > > I guess simple "return" (even when using line break) is still like > > single statement... > > Am I wrong? > > > > Last time I checked this only applied to single-line-statements. > Maybe it changed, though. Just sidestep the issue and invert the test ;-) (However, CodingStyle says nothing about single lines, only statements, and I tend to agree) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
