On Wed, 10 Aug 2011 18:42:59 +0200
Rafał Miłecki <zajec5@xxxxxxxxx> wrote:
> W dniu 10 sierpnia 2011 18:40 użytkownik Michael Büsch <m@xxxxxxx> napisał:
> > On Wed, 10 Aug 2011 18:11:27 +0200
> >> +/* Some chipsets need routing known for PCIe and 64-bit DMA */
> >> +static bool ssb_dma_translation_special_bit(struct ssb_device *dev)
> >> +{
> >> + u16 chip_id = dev->bus->chip_id;
> >> +
> >> + if (dev->id.coreid == SSB_DEV_80211)
> >> + return (chip_id == 0x4322 || chip_id == 43221 ||
> >> + chip_id == 43231 || chip_id == 43222);
> >> + return 0;
> >> +}
> >
> > ACK, apart from this coding style violation (missing curly braces).
>
> From kernel CodingStyle:
> > Do not unnecessarily use braces where a single statement will do.
> >
> > if (condition)
> > action();
>
> I guess simple "return" (even when using line break) is still like
> single statement...
> Am I wrong?
>
Last time I checked this only applied to single-line-statements.
Maybe it changed, though.
--
Greetings, Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
