Search Linux Wireless

Re: [PATCH 20/40] wl12xx: update BT coex configuration params

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2011-08-09 at 12:13 +0300, Eliad Peller wrote: 
> -	 * Defines whether the SG will force WLAN host to enter/exit PSM
> +	 * The maximum time WLAN can gain the antenna for
> +	 * in WLAN PSM / BT master/slave BR

"WLAN can gain the antenna for"... for what?


> +	/*
> +	 * The maximum time WLAN can gain the antenna for
> +	 * in WLAN PSM / BT master/slave EDR

Same here.


> +	/* ??? */

[...]

> +	/* ??? */

Can you figure out what this is? If not, add a "TODO: explain these
values".


> +	 * The threshold (percent) of max consequtive beacon misses before

s/consequtive/consecutive/


> +	/* ??? */

Same as above.


> +	CONF_SG_GENERAL_USAGE_BIT_MAP,



> +	 * Number of consequent BT voice frames not interrupted by WLAN

s/consequent/consecutive/



> @@ -357,17 +354,12 @@ static int wl1271_sta_hw_init(struct wl1271 *wl)
>  
>  	/* Beacon filtering */
>  	ret = wl1271_init_beacon_filter(wl);
>  	if (ret < 0)
>  		return ret;
>  
> -	/* FM WLAN coexistence */
> -	ret = wl1271_acx_fm_coex(wl);
> -	if (ret < 0)
> -		return ret;
> -

I guess this means that FM/WLAN coex is not used anymore.  Can you say
it in the commit log too?

-- 
Cheers,
Luca.

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux