On Tue, 2011-08-09 at 15:48 +0300, Eliad Peller wrote: > On Tue, Aug 9, 2011 at 3:13 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Mon, 2011-07-25 at 18:29 +0300, Eliad Peller wrote: > >> i'm not familiar enough with the off_channel flow, > >> but this one looks completely broken - we should > >> remain_off_channel if the work was started, and > >> the work's channel and channel_type are the same > >> as local->tmp_channel and local->tmp_channel_type. > >> > >> however, if wk->chan_type and local->tmp_channel_type > >> coexist (e.g. have the same channel type), we won't > >> remain_off_channel. > >> > >> this behavior was introduced by commit da2fd1f > >> ("mac80211: Allow work items to use existing > >> channel type.") > > > > Yeah this seems obvious. > > > > Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > > > > Now that I look at ieee80211_work_ct_coexists() itself again though it > > seems to do HT20 wrong? > > > hmm... yeah. > and also HT40 seems wrong (e.g. HT40 + NO_HT). Hm yeah. Well, since wk_ct is always NO_HT right now maybe we should remove this altogether? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html