On Mon, 2011-07-25 at 18:29 +0300, Eliad Peller wrote:
> i'm not familiar enough with the off_channel flow,
> but this one looks completely broken - we should
> remain_off_channel if the work was started, and
> the work's channel and channel_type are the same
> as local->tmp_channel and local->tmp_channel_type.
>
> however, if wk->chan_type and local->tmp_channel_type
> coexist (e.g. have the same channel type), we won't
> remain_off_channel.
>
> this behavior was introduced by commit da2fd1f
> ("mac80211: Allow work items to use existing
> channel type.")
Yeah this seems obvious.
Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Now that I look at ieee80211_work_ct_coexists() itself again though it
seems to do HT20 wrong?
> Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx>
> ---
> net/mac80211/work.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/mac80211/work.c b/net/mac80211/work.c
> index a94b312..3291958 100644
> --- a/net/mac80211/work.c
> +++ b/net/mac80211/work.c
> @@ -1068,8 +1068,8 @@ static void ieee80211_work_work(struct work_struct *work)
> continue;
> if (wk->chan != local->tmp_channel)
> continue;
> - if (ieee80211_work_ct_coexists(wk->chan_type,
> - local->tmp_channel_type))
> + if (!ieee80211_work_ct_coexists(wk->chan_type,
> + local->tmp_channel_type))
> continue;
> remain_off_channel = true;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
