Search Linux Wireless

Re: [PATCH 1/2] mac80211: refactor sta_info_insert_rcu to 3 main stages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 8, 2011 at 4:35 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> Just a cursory look, I'll send a more detailed review later, but I
> wanted to ask John to not merge this for now;
>
>> +static int sta_info_insert_adhoc(struct sta_info *sta) __acquires(RCU)
>
> _ibss would be preferred
>
>> +static int sta_info_insert_mgd(struct sta_info *sta) __acquires(RCU)
>
> _mgd is terribly misleading, this will be done for all modes other than
> IBSS.

Fair enough. the _ibss change is logical and understood.
The problem with the _mgd function is that it will be silly to call it
_non_ibss (or is it?)
Do you have a suggestion for a better name?

>
> johannes
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux