Just a cursory look, I'll send a more detailed review later, but I wanted to ask John to not merge this for now; > +static int sta_info_insert_adhoc(struct sta_info *sta) __acquires(RCU) _ibss would be preferred > +static int sta_info_insert_mgd(struct sta_info *sta) __acquires(RCU) _mgd is terribly misleading, this will be done for all modes other than IBSS. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html