On Thu, Jul 28, 2011 at 02:11:32PM -0700, Luis R. Rodriguez wrote: > On Thu, Jul 28, 2011 at 10:29 AM, Rajkumar Manoharan > <rmanohar@xxxxxxxxxxxxxxxx> wrote: > > Debugfs file location: > > <debugfs_mnt>/ieee80211/phy#/ath9k/base_eeprom > > > > Signed-off-by: Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxxxx> > > --- > > drivers/net/wireless/ath/ath9k/debug.c | 147 ++++++++++++++++++++++++++++++++ > > 1 files changed, 147 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k/debug.c > > index d1eb896..df71c72 100644 > > --- a/drivers/net/wireless/ath/ath9k/debug.c > > +++ b/drivers/net/wireless/ath/ath9k/debug.c > > @@ -1163,6 +1163,151 @@ static const struct file_operations fops_regdump = { > > .llseek = default_llseek,/* read accesses f_pos */ > > }; > > > > +static ssize_t read_file_base_eeprom(struct file *file, char __user *user_buf, > > + size_t count, loff_t *ppos) > > +{ > > + struct ath_softc *sc = file->private_data; > > + struct ath_hw *ah = sc->sc_ah; > > + struct ar9300_base_eep_hdr *pBase = NULL; > > + unsigned int len = 0, size = 1500; > > + ssize_t retval = 0; > > + char *buf; > > + > > + if (!AR_SREV_9300_20_OR_LATER(ah)) > > + return 0; > > This is really really cool stuff, but instead of doing this can we > instead implement this as a callback design which would enable other > hw revisions to be supported? If we do not then we need to make the > code branch out on each type of card. > Yeah. Let us have common cb and ath9k & ath9k_htc can make use of it. Thanks for your comments. -- Rajkumar -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html