On 07/20/2011 02:38 PM, Ben Hutchings wrote: > On Wed, 2011-07-20 at 12:18 +0300, Kalle Valo wrote: >> cfg80211 exports zero length register size as it currently only uses >> struct ethtool_regs.version to export struct wiphy.hw_version. > [...] > > The ethtool_regs::version field represents the version of the register > dump format. This may or may not relate to a hardware version. > > If you don't actually provide a register dump then don't implement this > operation. Then we have a problem as cfg80211 exports the hw version without any register dumps: static int cfg80211_get_regs_len(struct net_device *dev) { /* For now, return 0... */ return 0; } static void cfg80211_get_regs(struct net_device *dev, struct ethtool_regs *regs, void *data) { struct wireless_dev *wdev = dev->ieee80211_ptr; regs->version = wdev->wiphy->hw_version; regs->len = 0; } And this has been there a long time already. How cfg80211 should export hw version if this is not a proper way? Kalle -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html