On Wed, Jul 20, 2011 at 12:19 PM, Sedat Dilek <sedat.dilek@xxxxxxxxxxxxxx> wrote: > On Wed, Jul 20, 2011 at 3:39 AM, Nick Kossifidis <mickflemm@xxxxxxxxx> wrote: >> 2011/7/15 Pavel Roskin <proski@xxxxxxx>: >>> Both ath5k_hw and ath5k_softc represent one instance of the hardware. >>> This duplication is historical and is not needed anymore. >>> >>> Keep the name "ath5k_hw" for the merged structure and "ah" for the >>> variable pointing to it. "ath5k_hw" is shorter than "ath5k_softc", more >>> descriptive and more widely used. >>> >>> Put the combined structure to ath5k.h where the old ath5k_softc used to >>> be. Move some code from base.h to ath5k.h as needed. >>> >>> Remove memory allocation for struct ath5k_hw and the corresponding error >>> handling. Merge iobase and ah_iobase fields. >>> >>> Signed-off-by: Pavel Roskin <proski@xxxxxxx> >> >> Thanks a lot Pavel ;-) >> >> Acked-by: Nick Kossifidis <mickflemm@xxxxxxxxx> >> >> -- >> GPG ID: 0xD21DB2DB >> As you read this post global entropy rises. Have Fun ;-) >> Nick >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > Hi, > > I have tested this patch on top of linux-next (next-20110720) and it fails: > > In file included from > /mnt/sdb3/linux-kernel/linux-3.0-rc7/debian/build/source_i386_none/drivers/net/wireless/ath/ath5k/caps.c:24:0: > /mnt/sdb3/linux-kernel/linux-3.0-rc7/debian/build/source_i386_none/drivers/net/wireless/ath/ath5k/ath5k.h:1072:24: > error: field 'toggleq' has incomplete type > /mnt/sdb3/linux-kernel/linux-3.0-rc7/debian/build/source_i386_none/drivers/net/wireless/ath/ath5k/ath5k.h:1191:24: > error: field 'rxtq' has incomplete type > /mnt/sdb3/linux-kernel/linux-3.0-rc7/debian/build/source_i386_none/drivers/net/wireless/ath/ath5k/ath5k.h:1198:24: > error: field 'txtq' has incomplete type > /mnt/sdb3/linux-kernel/linux-3.0-rc7/debian/build/source_i386_none/drivers/net/wireless/ath/ath5k/ath5k.h:1203:24: > error: field 'calib' has incomplete type > /mnt/sdb3/linux-kernel/linux-3.0-rc7/debian/build/source_i386_none/drivers/net/wireless/ath/ath5k/ath5k.h:1206:24: > error: field 'beacontq' has incomplete type > /mnt/sdb3/linux-kernel/linux-3.0-rc7/debian/build/source_i386_none/drivers/net/wireless/ath/ath5k/ath5k.h:1225:24: > error: field 'ani_tasklet' has incomplete type > make[9]: *** [drivers/net/wireless/ath/ath5k/caps.o] Error 1 > make[8]: *** [drivers/net/wireless/ath/ath5k] Error 2 > make[7]: *** [drivers/net/wireless/ath] Error 2 > make[6]: *** [drivers/net/wireless] Error 2 > make[5]: *** [drivers/net] Error 2 > make[5]: *** Waiting for unfinished jobs.... > > Just wanna let you know. > > Please, let me know if I should test on top of other trees like > wireless-testing GIT or I am missing something in my kernel-config > file. > Thanks. > > Regards, > - Sedat - > Attached patch fixes the build-breakage here. - Sedat -
Attachment:
ath5k-Add-missing-include-to-ath5k.h.patch
Description: plain/text
