Correcting most of the -1 return-values that this driver's ioctl handlers
return. They have been changed to the closest corresponding errno macro.
Unfortunately, very few of these could be tested! Often, wext does not care
about the specifics of the failure; it just checks for a negative
return-value. So these bugs do not propagate to the user.
Without instrumenting the code (of the driver, or of wext), this left
very few testables! eg the following (note the ampersand)
iwlist wlan2 scan & iwconfig wlan2 ap any
was the only way of triggering one of the failures.
Prior to the tests, I spent a lot of time on verifying the call chains.
The git-log of this file includes a few other such corrections to the
return values. So this patch should fit-in well.
Ali Bahar (2):
staging: r8712u: Most return-values changed from -1 to proper errno
macros.
staging: r8712u: checkpatch errors: trailing whitespace on 2 lines.
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 121 +++++++++++++++++++++----
1 files changed, 105 insertions(+), 16 deletions(-)
--
1.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
