On Tue, Jun 14, 2011 at 10:52:20AM -0700, Henry Ptasinski wrote: > On Fri, Jun 10, 2011 at 04:17:04AM -0700, Jonas Gorski wrote: > > Hi Arend, > > > > On 10 June 2011 11:52, Arend van Spriel <arend@xxxxxxxxxxxx> wrote: > > > Hi Jonas, > > > > > > You are right as with previous mips related patches. Consider this a first > > > step which does not change functionality but aims to use the proper linux > > > provided macros instead of our own incarnations. > > > > Actually as far as I can tell this changes (non-)functionality: With > > the broken big endiness check the driver probably just doesn't work > > properly on MIPS BE systems, because some endianess conversion is > > missing*. With the endianess check fixed, the special handling for the > > Broadcom MIPS get's enabled, potentially crashing the system (or > > changing random registers), thus making it *more* broken for non BMIPS > > systems. Therefore I'd rather consider this a regression. Especially > > since (AFAIK) the BMIPS systems that can take advantage of this aren't > > supported in Linux (yet). > > > > If it were just making things less efficient, I wouldn't be > > complaining (at least not that much ;-). If you can say that this is a > > code path that isn't taken anyway, then my point is moot (for now). I > > don't know the driver enough to tell that. > > > > Jonas > > > > *assuming brcm80211 depends on this on BE systems and it isn't just an > > optimization > > > Greg, > > Can you drop this patch and take the rest in the series? The other patches > don't depend on this one. Will do. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
