Search Linux Wireless

Re: [PATCH 12/21] staging: brcm80211: use __BIG_ENDIAN macro in dma.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9 June 2011 16:44, Roland Vossen <rvossen@xxxxxxxxxxxx> wrote:
> From: Arend van Spriel <arend@xxxxxxxxxxxx>
>
> The source file dma.c used a macro definition that indicated a big endian
> platform. The linux tree has its own macro determined by architecture and/or
> kernel configuration. This byteorder macro is __BIG_ENDIAN. This is now used
> in dma.c.

While this replacement is technically correct, the check itself is
wrong and should be fixed instead. Currently it assumes that __mips__
means Broadcom MIPS; but if it isn't, then there's likely no
SI_SDRAM_SWAPPED and any access there will in best case do nothing
(but more like hang the system).

Use either CONFIG_BCM47XX or CONFIG_BCM63XX to check for the BMIPS
platforms this is probably intended for (I'm not 100% sure if BCM63XX
has the swapped memory space - better check with your xDSL people ;-).


Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux