Hi Johannes,
* Johannes Berg <johannes@xxxxxxxxxxxxxxxx> [2011-06-22 08:56:11 +0200]:
> On Tue, 2011-06-21 at 19:05 -0300, Gustavo F. Padovan wrote:
>
> > > static int __init nfc_init(void)
> > > {
> > > + int rc;
> > > +
> > > printk(KERN_INFO "NFC Core ver %s\n", VERSION);
> > >
> > > - return class_register(&nfc_class);
> > > + rc = class_register(&nfc_class);
> > > + if (rc)
> > > + goto err;
> >
> > Just return rc here and get rid of the label.
>
>
> Seriously, please trim your quotes. If you're commenting on a specific
> piece of code, you can well remove all the code you're not commenting on
> like I did above.
Sorry, I didn't realize that it was so big. Also I usually forget to trim the
beginning of the patch. Have to get used to that.
Gustavo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
