Search Linux Wireless

Re: [RFC][PATCH v2 3/7] NFC: add nfc generic netlink interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2011-06-21 at 19:05 -0300, Gustavo F. Padovan wrote:

> >  static int __init nfc_init(void)
> >  {
> > +	int rc;
> > +
> >  	printk(KERN_INFO "NFC Core ver %s\n", VERSION);
> >  
> > -	return class_register(&nfc_class);
> > +	rc = class_register(&nfc_class);
> > +	if (rc)
> > +		goto err;
> 
> Just return rc here and get rid of the label.


Seriously, please trim your quotes. If you're commenting on a specific
piece of code, you can well remove all the code you're not commenting on
like I did above.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux