Search Linux Wireless

Re: [PATCH v3] 802.11n frame injection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/6/6 Johannes Berg <johannes@xxxxxxxxxxxxxxxx>:
> On Sat, 2011-06-04 at 19:42 +0200, Matteo Croce wrote:
>
>> + Â Â Â Â Â Â case IEEE80211_RADIOTAP_RATE: {
>> + Â Â Â Â Â Â Â Â Â Â struct ieee80211_supported_band *sband =
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â tx->local->hw.wiphy->bands[tx->channel->band];
>> + Â Â Â Â Â Â Â Â Â Â info->control.rates[0].idx = 0;
>> + Â Â Â Â Â Â Â Â Â Â if (*iterator.this_arg) {
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â int i;
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â for (i = 0; i < sband->n_bitrates; i++)
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â if (sband->bitrates[i].bitrate ==
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â *iterator.this_arg * 5) {
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â info->control.rates[0].idx = i;
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â break;
>
> I don't think you should set the index if the bitrate doesn't exist.
>
> Also, have you actually _tested_ this patch? I see nothing that would
> cause rate control to be skipped, so rate control should always override
> the data you set up here.
>
> johannes
>
>

Actually I use this patch on many devices.
The rate control is not an issue as this patch is intended for
injecting in monitor mode

-- 
Matteo Croce
OpenWrt Developer
Â_______ Â Â Â Â Â Â Â Â Â Â ________ Â Â Â Â__
| Â Â Â |.-----.-----.-----.| Â| Â| Â|.----.| Â|_
| Â - Â || Â_ Â| Â-__| Â Â || Â| Â| Â|| Â _|| Â _|
|_______|| Â __|_____|__|__||________||__| Â|____|
    Â|__| W I R E L E S S  F R E E D O M
ATTITUDE ADJUSTMENT (bleeding edge) --------------
Â* 1/4 oz Vodka   ÂPour all ingredents into mixing
Â* 1/4 oz Gin    Âtin with ice, strain into glass.
Â* 1/4 oz Amaretto
Â* 1/4 oz Triple sec
Â* 1/4 oz Peach schnapps
Â* 1/4 oz Sour mix
Â* 1 splash Cranberry juice
-----------------------------------------------------
ÿô.nlj·Ÿ®‰­†+%ŠË±é¥Šwÿº{.nlj·¥Š{±ÿ«zW¬³ø¡Ü}©ž²ÆzÚj:+v‰¨þø®w¥þŠàÞ¨è&¢)ß«a¶Úÿûz¹ÞúŽŠÝjÿŠwèf



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux