On Thu, 2011-04-21 at 00:44 -0700, Lennert Buytenhek wrote:
> On Tue, Apr 19, 2011 at 10:16:21PM +0530, Nishant Sarmukadam wrote:
>
> > - if (txq->len >= MWL8K_TX_DESCS) {
> > - if (start_ba_session) {
> > - spin_lock(&priv->stream_lock);
> > - mwl8k_remove_stream(hw, stream);
> > - spin_unlock(&priv->stream_lock);
> > + /* Mgmt frames that go out frequently are probe responses.
> > + * Other mgmt frames got out relatively infrequently.
> > + * Hence reserve 2 buffers so that other mgmt frames do not get
> > + * dropped due to an already queued probe response in one of
> > + * the reserved buffers.
> > + */
>
> Comment formatting..
>
>
> > + if (txq->len >= (MWL8K_TX_DESCS - 2)) {
> > + if ((mgmtframe == false) ||
> > + (txq->len == MWL8K_TX_DESCS)) {
> > + if (start_ba_session) {
> > + spin_lock(&priv->stream_lock);
> > + mwl8k_remove_stream(hw, stream);
> > + spin_unlock(&priv->stream_lock);
> > + }
>
> ..and lots of superfluous parentheses here:
>
> txq->len >= MWL8K_TX_DESCS - 2
> mgmtframe == false
> txq->len == MWL8K_TX_DESCS
I will address both these comments in patch set V3.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
