On Thu, 2011-04-21 at 00:42 -0700, Lennert Buytenhek wrote: > On Tue, Apr 19, 2011 at 10:16:20PM +0530, Nishant Sarmukadam wrote: > > > From: Pradeep Nemavat <pnemavat@xxxxxxxxxxx> > > > > Timestamp tx packets using a HW micro-second timer. > > This timestamp will be compared to the current timestamp > > in the hardware and if the difference is greater than 500ms, > > the packet will be dropped. > > > > Signed-off-by: Pradeep Nemavat <pnemavat@xxxxxxxxxxx> > > Signed-off-by: Nishant Sarmukadam <nishants@xxxxxxxxxxx> > > --- > > drivers/net/wireless/mwl8k.c | 12 ++++++++++++ > > 1 files changed, 12 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c > > index 7968301..aca0139 100644 > > --- a/drivers/net/wireless/mwl8k.c > > +++ b/drivers/net/wireless/mwl8k.c > > @@ -1792,6 +1792,14 @@ static inline void mwl8k_tx_count_packet(struct ieee80211_sta *sta, u8 tid) > > tx_stats->pkts++; > > } > > > > +/* HW micro second timer register > > + * located at offset 0xA600. This > > + * will be used to timestamp tx > > + * packets. > > + */ > > + > > +#define MWL8K_HW_TIMER_REGISTER (priv->regs + 0xA600) > > 1. Ugly implicit 'priv' argument here. :-( > > Please just do something like: > > #define MWL8K_A2H_INT_RX_READY (1 << 1) > #define MWL8K_A2H_INT_TX_DONE (1 << 0) > + > +/* Misc registers */ > +#define MWL8K_HW_TIMER_REGISTER 0x0000a600 > > #define MWL8K_A2H_EVENTS (MWL8K_A2H_INT_DUMMY | \ > MWL8K_A2H_INT_CHNL_SWITCHED | \ > > and then just use it as ioread32(priv->regs + MWL8K_HW_TIMER_REGISTER). > > Ok, will send out patch set V3 incorporating this change. > 2. Does this register exist on 8687/superfly3, or is it SJ only? Yes, this does exist on 8687 and superfly3 as well. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html