Paulius Zaleckas wrote:
>
>
> On 04/20/2011 08:30 AM, Sujith wrote:
> > From: Sujith Manoharan<Sujith.Manoharan-DlyHzToyqoxBDgjK7y7TUQ@xxxxxxxxxxxxxxxx>
> >
> > * Register the driver's maximum ampdu subframe limit to mac80211.
> > * Cleanup the target capabilities structure and fix an endian issue.
> > * Fix BTCOEX by sending a command to the target when the BT priority
> > changes.
> > * Bump the required firmware version to 1.1
> >
> > Signed-off-by: Sujith Manoharan<Sujith.Manoharan-DlyHzToyqoxBDgjK7y7TUQ@xxxxxxxxxxxxxxxx>
>
> [...]
>
> > + /*
> > + * Check if the available FW matches the driver's
> > + * required version.
> > + */
> > + if (priv->fw_version_major< MAJOR_VERSION_REQ ||
> > + priv->fw_version_minor< MINOR_VERSION_REQ) {
>
> Wrong version check logic. Version 2.0 will fail this 1.1 check, because
> of minor version number.
> Should be something like:
> if (priv->fw_version_major < MAJOR_VERSION_REQ ||
> (priv->fw_version_major == MAJOR_VERSION_REQ &&
> priv->fw_version_minor < MINOR_VERSION_REQ))
>
Actually, I think a much more strict check is required, since the driver can't
be compatible with both a lower or a higher version of the firmware.
Sujith
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
