Search Linux Wireless

Re: [PATCH 2/5] ath9k_htc: Fix AMPDU subframe handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/20/2011 08:30 AM, Sujith wrote:
From: Sujith Manoharan<Sujith.Manoharan@xxxxxxxxxxx>

* Register the driver's maximum ampdu subframe limit to mac80211.
* Cleanup the target capabilities structure and fix an endian issue.
* Fix BTCOEX by sending a command to the target when the BT priority
   changes.
* Bump the required firmware version to 1.1

Signed-off-by: Sujith Manoharan<Sujith.Manoharan@xxxxxxxxxxx>

[...]

+	/*
+	 * Check if the available FW matches the driver's
+	 * required version.
+	 */
+	if (priv->fw_version_major<  MAJOR_VERSION_REQ ||
+	    priv->fw_version_minor<  MINOR_VERSION_REQ) {

Wrong version check logic. Version 2.0 will fail this 1.1 check, because of minor version number.
Should be something like:
if (priv->fw_version_major < MAJOR_VERSION_REQ ||
    (priv->fw_version_major == MAJOR_VERSION_REQ &&
     priv->fw_version_minor < MINOR_VERSION_REQ))

+		dev_err(priv->dev, "ath9k_htc: Please upgrade to FW version %d.%d\n",
+			MAJOR_VERSION_REQ, MINOR_VERSION_REQ);
+		return -EINVAL;
+	}
+
  	return 0;
  }

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux