Hi, > > Ok Jouni and I just discussed this briefly, and it looks like there is > > indeed a special case where the GTK is also set as the default TX key: > > this case is when the station requested "no pairwise" or when the AP did > > the same thing in the configuration. > > From the wpa_supplicant debug log generated by Amit, it seems that > set_default_key() is called while installing PTK to the driver. Is it > expected? > > WPA: Installing PTK to the driver. > WPA: RSC - hexdump(len=6): 00 00 00 00 00 00 > wpa_driver_nl80211_set_key: ifindex=12 alg=2 addr=0x80a7168 key_idx=0 set_tx=1 seq_len=6 key_len=32 > addr=00:1b:2f:55:79:7e > > The complete log file is attached for your reference. Hmm. I'll need to look at that in more detail. But yeah, set_tx=1 indicates that it'll call set_default_key. > > Is it possible that this just happens to be the case in your tests? It > > looks like that would be rather strange, but that's a corner case where > > the supplicant would possibly set the GTK as the default key. > > Not the same corner case. In our test both pairwise and groupwise are configured. > > > > > In any case, this patch seems wrong in that you should never return > > success if the operation actually failed. > > Could you please advise how we should resolve this? What happens if you just reject the set_default_key and return -EINVAL instead of 0? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
