On Sun, 2011-04-03 at 10:02 +0200, Johannes Berg wrote: > On Fri, 2011-04-01 at 18:36 -0700, Bing Zhao wrote: > > From: Amitkumar Karwar <akarwar@xxxxxxxxxxx> > > > > When testing wpa_supplicant with 'nl80211' driver to connect > > to an AP with WPA/WPA2 security, we notice the followings: > > > > 1) add_key is called firstly with the key from cfg80211 > > 2) set_defaut_key is called next > > > > set_default_key() is specific to WEP keys and should not be > > called in case of WPA/WPA2 security. The set_default_key() > > won't be called if wpa_supplicant uses "-Dwext" option, > > but it's been called if "-Dnl80211" option is specified. > > > > We can fix this issue by adding a check to return from > > set_default_key() if WEP key is not configured. > > Hmmm. Yeah this seems like it shouldn't be happening, but maybe checking > should be in cfg80211 and it should reject the supplicant's call? Ok Jouni and I just discussed this briefly, and it looks like there is indeed a special case where the GTK is also set as the default TX key: this case is when the station requested "no pairwise" or when the AP did the same thing in the configuration. Is it possible that this just happens to be the case in your tests? It looks like that would be rather strange, but that's a corner case where the supplicant would possibly set the GTK as the default key. In any case, this patch seems wrong in that you should never return success if the operation actually failed. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
