On Fri, 01 Apr 2011 22:22:01 +0300 Kalle Valo <kvalo@xxxxxxxxxx> wrote: > > Then enum wl1251_cmd_ps_mod in cmd.h is renamed and moved to wl1251.h as it > > is a state rather than chip level command. > > But now you are moving a firmware interface value outside cmd.h. I was > thinking that you would touch wl1251_cmd_ps_mod at all, instead just > create a new enum wl1251_station_mode which will be used as the driver > state variable. > > That way it's clear which enum is for the firmware interface and which > one is an internal variable. > I agree, I was blind to see that the wl1251_cmd_ps_mode indeed sends the value to chip... I'll send an update where the enum wl1251_cmd_ps_mod is kept intact. -- Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
