Jarkko Nikula <jhnikula@xxxxxxxxx> writes: > RFC for WL1251 idle mode support brought a few issues that are worth to > update before adding the idle mode support. > [...] > Then enum wl1251_cmd_ps_mod in cmd.h is renamed and moved to wl1251.h as it > is a state rather than chip level command. But now you are moving a firmware interface value outside cmd.h. I was thinking that you would touch wl1251_cmd_ps_mod at all, instead just create a new enum wl1251_station_mode which will be used as the driver state variable. That way it's clear which enum is for the firmware interface and which one is an internal variable. To make it even more clear we could change the function to this: int wl1251_cmd_ps_mode(struct wl1251 *wl, enum wl1251_cmd_ps_mod mode); Otherwise patch looks very good to me. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
