Search Linux Wireless

Re: [PATCH] mac80211: rename RX_FLAG_TSFT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arend,

> > +#if 0
> > +	/* Clearly, this is bogus -- reading the TSF now is wrong */
> >  	wlc_read_tsf(wlc, &tsf_l, &tsf_h);	/* mactime */
> >  	rx_status->mactime = tsf_h;
> >  	rx_status->mactime <<= 32;
> >  	rx_status->mactime |= tsf_l;
> > -	rx_status->flag |= RX_FLAG_TSFT;
> > +	rx_status->flag |= RX_FLAG_MACTIME_MPDU; /* clearly wrong */
> > +#endif
> 
> This piece of code has been '#if 0'-ed by you. Could you elaborate why  
> this is clearly wrong? Because of this the variables tsf_l and tsf_h are  
> not being used hence the warning.

include/net/mac80211.h:

 * @mactime: value in microseconds of the 64-bit Time Synchronization Function
 *      (TSF) timer when the first data symbol (MPDU) arrived at the hardware.


Not sure what else to say ... reading the TSF when processing the frame
in software is clearly bogus.

johannes


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux