Search Linux Wireless

Re: [PATCH] mac80211: rename RX_FLAG_TSFT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 23 Feb 2011 15:06:08 +0100, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:

 drivers/staging/brcm80211/sys/wlc_mac80211.c  |    5 ++++-

Hi Johannes,

2.6.38 has landed in staging-2.6 repository and I built our driver. It gives build warning on above mentioned file.


--- wireless-testing.orig/include/net/mac80211.h 2011-02-23 - RX_FLAG_TSFT = 1<<7,
+	RX_FLAG_MACTIME_MPDU	= 1<<7,

wireless-testing.orig/drivers/staging/brcm80211/sys/wlc_mac80211.c 2011-02-23 15:03:58.000000000 +0100 +++ wireless-testing/drivers/staging/brcm80211/sys/wlc_mac80211.c 2011-02-23 15:04:48.000000000 +0100
@@ -6818,11 +6818,14 @@ prep_mac80211_status(struct wlc_info *wl
 	ratespec_t rspec;
 	unsigned char *plcp;
+#if 0
+	/* Clearly, this is bogus -- reading the TSF now is wrong */
 	wlc_read_tsf(wlc, &tsf_l, &tsf_h);	/* mactime */
 	rx_status->mactime = tsf_h;
 	rx_status->mactime <<= 32;
 	rx_status->mactime |= tsf_l;
-	rx_status->flag |= RX_FLAG_TSFT;
+	rx_status->flag |= RX_FLAG_MACTIME_MPDU; /* clearly wrong */
+#endif

This piece of code has been '#if 0'-ed by you. Could you elaborate why this is clearly wrong? Because of this the variables tsf_l and tsf_h are not being used hence the warning.

Gr. AvS
--
"The most merciful thing in the world, I think, is the inability of the human
mind to correlate all its contents." - "The Call of Cthulhu"

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux